Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double sort from Enter key press #2004

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lalong13
Copy link
Contributor

In the current implementation, using the enter key triggers the sort change twice. Once due to using enter key on a button, which by default (in Chrome at least) triggers that button's onClick, and the second time due to the onKeyUp function. Space bar is currently the work around, but for keyboard only users (blind/low vision) this is broken behavior.

In the current implementation, using the enter key triggers the sort change twice. Once due to using enter key on a button, which by default (in Chrome at least) triggers that button's onClick, and the second time due to the onKeyUp function. Space bar is currently the work around, but for keyboard only users (blind/low vision) this is broken behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant